api key cache ttl #160
Merged
api key cache ttl #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poundifdef
reviewed
Apr 15, 2024
pkg/api/api.go
Outdated
| @@ -52,6 +56,15 @@ func NewScratchDataAPI( | |||
| return nil, err | |||
| } | |||
|
|
|||
| apiKeyTTL := conf.API.APIKeyCacheTTL | |||
| if apiKeyTTL == 0 { | |||
There was a problem hiding this comment.
Does a TTL of 0 mean "we do not cache anything"? If so, then i'm okay removing this if-statement so that there's some way to disable the cache.
There was a problem hiding this comment.
For this library, the answer seems to be yes and no? While the item will instantly expire, any lookup that is less than an hour https://github.com/jellydator/ttlcache/blob/v3/cache.go#L537 will succeed, but return an item that is expired, which you could check with item.ExpiresAt() < time.Now().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #159