This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
Refactor3d #507
Merged
Refactor3d #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the Travis auto-build support conditional compiling? I'd like to still use it and build upon it. |
|
I don't know how to configure Travis but if it supports either passing command line arguments to the compiler (like "-define=namespace::variable_name,value") or using a flex-config.xml file then it can support conditional compilation. See also: http://help.adobe.com/en_US/flex/using/WS2db454920e96a9e51e63e3d11c0bf69084-7abd.html |
|
I think I just found how to do it. I'll see if I can get it working. |
|
Great! We'll have to coordinate the proper website changes to support this. 👍 |
To simplify building and debugging the 3D rendering code, I moved it into the main src/ directory. This breaks the AIR 2.6 build, but an upcoming change will fix that.
The 'SCRATCH::allow3d' flag now controls 3D-related code.
Thanks @sclements for finding this problem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the 3D rendering code dynamically from a separate SWF, this change uses conditional compilation to build the editor SWF with or without 3D features depending on the value of a new SCRATCH::allow3d flag.
It might be more effective to view the diffs for individual commits, since the first commit moves several files.
This change will require updates to the way Travis builds this code.