Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rschamp I pulled out the UI button that used to be in this PR, so now it implements only the sound library redux actions and component. I documented in
@todo
s all the places this has some strange interactions with the VM. I worked with @ericrosenbaum on the audio loading stuff, when that lands it'll clear up some of those.Here are the main things I learned going through this
vm.runtime.audioEngine
because any effects that are applied would also be applied to the library (maybe cool? probably not?) See these linesscratch-storage
. Having loaded callbacks would allow a sound to be loaded and then played on demand, rather than what I'm doing now loading all the sounds in the library when the library is mounted. See these linesaddSound
function that also handles the loading of new sounds. See these lines Update The new scratch-storage integration will force the vm to have this functionality! Hooray!addItemChosen
callback for the actual select before the double click action.