Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually upload projects using xhr, rather than scratch-storage #4015

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Manually upload projects using xhr, rather than scratch-storage #4015

merged 1 commit into from
Dec 11, 2018

Conversation

rschamp
Copy link
Contributor

@rschamp rschamp commented Dec 10, 2018

Resolves #3950.

Unfortunately the design of scratch-storage doesn't make having multiple distinct POST urls easy at the moment. So for the time being, just make this request ourselves.

We need to follow up, filed in scratchfoundation/scratch-storage#61

Manually save using xhr
2812720 
Resolves scratchfoundation#3950.

Unfortunately the design of scratch-storage doesn't make having multiple distinct POST urls easy at the moment. So for the time being, just make this request ourselves.
@rschamp rschamp added this to the December 2018 milestone Dec 10, 2018
@rschamp rschamp changed the title Manually save using xhr Manually upload projects using xhr, rather than scratch-storage Dec 10, 2018
@thisandagain
Copy link
Contributor

/cc @thisandagain

@towerofnix towerofnix mentioned this pull request Dec 11, 2018
Open
benjiwheeler
benjiwheeler approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@benjiwheeler benjiwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested this with regular saving, saving as a copy, creating a new project, and remixing.

Only thing that doesn't seem right is that my project thumbnails aren't loading in MyStuff, but I imagine that's just a local/remote config thing.

@benjiwheeler benjiwheeler assigned rschamp and unassigned benjiwheeler Dec 11, 2018
@rschamp rschamp merged commit a83601c into scratchfoundation:develop Dec 11, 2018
@rschamp rschamp deleted the project-server-reconfig branch December 11, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjiwheeler benjiwheeler benjiwheeler approved these changes

Assignees

@rschamp rschamp

Labels
pr - good to merge
Projects
None yet
Milestone
December 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rschamp @thisandagain @benjiwheeler