Implements BLE manufacturer data-feature in LEGO BOOST extension #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itialised LEGO BOOST Move Hubs
|
Reason for blocked label: We discovered during a test that while the Mac-version of Scratch Link doesn't seem to mind being passed a filter it doesn't know, the Windows-version will not discover anything. |
|
With the release of Scratch Link 1.2, this PR technically isn't blocked anymore. PSA: If this PR gets merged and a user is using Scratch Link 1.1 on Windows and use the LEGO BOOST extension, they will get an error when trying to connect. |
|
@cwillisf @ericrosenbaum Would you mind giving this a re-review? |
cwillisf
approved these changes
Sep 16, 2019
|
Thanks @cwillisf ! After discussing with @ericrosenbaum, we'll hold off on merging until we've done some more testing. |
ericrosenbaum
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#2230
Proposed Changes
Adds a filter to the
scan()-function so that only properly initialised LEGO BOOST Move Hubs are discovered and connected to.Reason for Changes
In Move Hub firmware 2.0.00.0017 the Move Hub briefly appears with a non-connectable MAC-address. Additionally, while non-connectable, no advertisement data is found. By implementing this filter, the non-connectable device will not pass through it.