Change wait to use a promise instead of being called every frame #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmickel
approved these changes
Jun 8, 2017
|
Thanks for helping us look at this bug @tmickel! |
stefania11
pushed a commit
to mitmedialab/cognimates-vm
that referenced
this pull request
Mar 31, 2018
…oder-1.2.0 Update wav-encoder to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#591
Proposed Changes
Change wait block to work like wait beats block, use a promise which makes it not be called every frame
Reason for Changes
Calling the wait function every frame with different random numbers generally causes it to finish after the smallest random number