Fix GH 1102: Don’t allow duplicate strings in a single l10n file #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check_duplicate_strings to test for duplicates in a single file. removed duplicates - tried to keep the more generic ‘key’
thisandagain
suggested changes
Jan 19, 2017
| * Check that there are no duplicate strings in any individual l10n json file. | ||
| */ | ||
| var path = require('path'); | ||
| //var fs = require('fs'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| subdir.pop(); | ||
| var name = routes[v].name; | ||
| try { | ||
| var ids = require(path.resolve(__dirname, '../../src/views/' + subdir.join('/') +'/l10n.json')); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Still needs try/catch because readFileSync throws an error if file doesn’t exist.
chrisgarrity
force-pushed
the
gh1102-dup-strings
branch
from
ebc0f23
to
152fa80
Compare
chrisgarrity
added a commit
to chrisgarrity/scratch-www
that referenced
this pull request
May 4, 2020
Check duplicates was added to prevent errors in the conversion to/from PO files back before we switched to Transifex. See scratchfoundation#1150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check_duplicate_strings to test for duplicates in a single file.
removed duplicates - tried to keep the more generic ‘key’
Testing:
Make sure that strings appear not ids. E.g., 'Tutorial' not 'ttt.tutorial'