Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project stats icons always opaque #7358

Merged

Conversation

benjiwheeler
Copy link
Contributor

Resolves:

follow-on to #7264

Changes:

sets opacity of the new project page stats icons to default of 100% (instead of 50%), to match the intention behind their design.

background-image: url("/svgs/project/love-gray.svg");
}
}

.project-loves.loved {

&:before {
opacity: 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be removed, since the opacity isn't .5 to start with

Copy link
Contributor

@tomlum tomlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤘

@benjiwheeler benjiwheeler merged commit 8e84a62 into scratchfoundation:develop Jan 31, 2023
@benjiwheeler benjiwheeler deleted the project-icons-opacity branch January 31, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants