Insert tx-content attributes on components that need them #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added TxDiv and TxSpan components to add `tx-content=…` to places that need it for Transifex Live.
rschamp
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the gotchas for Transifex Live is that while most of the directives are through classes, there are a couple of things that use custom attributes (tx-content) which are stripped out by React. People have been asking for custom attributes on React since 2013 (facebook/react#140), and it actually looks like they may be getting around to adding them. In the meantime, I used what seemed like the recommended workaround from this comment: facebook/react#140 (comment).
I created TxDiv and TxSpan to wrap div and span components that need tx-content values.
I think it looks a bit messy, so I guess I'm wondering if this is the best way to do it. Or just live with it this way until react actually fixes 140.