extend skin and cape api #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add model field - use structs for skin and head cache entry
- add testing profile "Herbert" that has no custom skin (and cape)
This was
linked to
issues
Mar 11, 2024
|
scrayos
requested changes
Mar 13, 2024
scrayos
reviewed
Mar 18, 2024
scrayos
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Breaking Changes
The breaking changes require the Redis kv-store to be cleared for
skinandhead. As this is a pre 1.0 version, no auto-migration is provided. Additionally, the any clients have to be updated to support the new proto definition.