Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve application configuration #85

Merged
merged 9 commits into from
Mar 28, 2024
Merged

improve application configuration #85

merged 9 commits into from
Mar 28, 2024

Conversation

wagpa
Copy link
Contributor

@wagpa wagpa commented Mar 27, 2024 •
edited

Changes

  • Set duration (e.g. expiry) with iso string or number (of seconds)
  • allow setting config file locations from env
  • allow requesting signed profiles (global setting, so independent of cache)
  • allow setting log level filter

Breaking Changes

  • remove local.toml for config.toml
  • embed default config at compile time
  • move debug setting from top level to sentry.debug (it was only used by sentry anyway)

This was linked to issues Mar 27, 2024
Improve config layout/fields/defaults #53
Closed
Add configuration option to request signed profiles #58
Closed
Default custom config location is inconvenient on Kubernetes #69
Closed
Add setting for log level #84
Closed
@wagpa wagpa changed the title improve application aconfiguration improve application configuration Mar 28, 2024
@wagpa wagpa requested a review from scrayos March 28, 2024 17:21
@wagpa wagpa marked this pull request as ready for review March 28, 2024 17:21
@scrayos scrayos merged commit bf7ccfe into main Mar 28, 2024
4 checks passed
@scrayos scrayos deleted the dev/improved-settings branch March 28, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrayos scrayos scrayos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wagpa @scrayos