Deceiving library reliability

[lifenautjoe]

The module has a build status badge on green deceiving the public about the reliability of the package.
The only existing test :

describe('cp-cli', () => {
  it('should do anything', () => {
    expect(true).to.be.true();
  });

[screendriver]

Yes that's true. I know that because I have written this one. This has some reasons:

1. this tool is excatly one day old. I needed that tool immediately for a private project and I had no time to write a useful test.
2. when you look at my code the only thing that I call is yargs and fs-extra. So the only thing to test would be to test that these both libraries are working as expected. It is only a simple wrapper around fs-extra#copy().
3. I don't have any idea how to test the argumenst that yargs is reading because yargs read these from the command line.

So if you have any idea how to write a unit test for that any pull request would be welcome.

[lifenautjoe]

I was going to make the exact same library, hence I found this one.
For the fs-extra, I do not know chai but we should use spies to check that the correct method was called with the correct arguments. For yargs, I'll investigate.

[lifenautjoe]

Sharing the knowledge: https://jstesting.jcoglan.com/cli.pdf

[screendriver]

Thank you for sharing the link 👍

But as I said: at the moment there is no meaningfulness to write tests. The only thing we would test is that yargs and fs-extra are working as expected 😉 You shouldn't write unit tests that only test external libraries.

[lifenautjoe]

No.. we would test that the cli application indeed uses the first argument as source and the second one as target and that fse.copy is called with these arguments in the correct order.

If this seems too trivial to you then why not remove the build passing badge? It should be trivial for users too right?

[screendriver]

I removed cp-cli-test.js for you. This file should originally be a skeleton for future unit tests.

The build passing badge remains because a "build" consists of two steps:

1. Code linting
2. Unit testing

I will add the one unit test that you wishes later when I have more time for that.

[lifenautjoe]

I'll write it, today, as soon as I'm off work.

[screendriver]

Fixed with ff36430

[lifenautjoe]

Awesome.