Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to configure logging levels. #83

Closed
wants to merge 281 commits into from

Conversation

DylanLacey
Copy link
Contributor

This changes allows the Screener config to accept an ngrok object with the keys logFile and logLevel, which are passed through to ngrok.

Prefix slug when PR src and dest branch names are equal
xwa130saucer and others added 26 commits December 3, 2019 15:27
The new version of Semaphore changed some of the environment variables.

Unfortunately, there's no explicit way to determine if you're using 1.0 or 2.0,
so this PR checks for the original variables first, then the 2.0 variables.

For Branch information, this PR relies on the 'Workflow ID'. This means that
Github status is updated for the same "Branch" across all pipelines in the same
Semaphore 2.0 run.  From their docs, this seems to most closely match how
Semaphore integrates with Github.  The alternative would be to use Pipeline ID.
Added details of Semaphore 2.0 support to CHANGELOG.md
Current validation will fail for anything other than X.X, but historically `X` and `X.X.X` was supported as well.

This reverts the restriction, while maintaining the desired validation.

We don't need to update the regex where `launchSauceConnect` is true, because Sauce only supports `X.X`.
@vrunoa
Copy link
Contributor

vrunoa commented Jun 3, 2022

@DylanLacey closing this. If needed let us know.

@vrunoa vrunoa closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants