Support for React 17?

[GiriB]

We are moving our apps to React 17. Are there any plans to update this package to be compatible with React 17 as well?

From the React 17 has not major breaking changes so hopefully this wont be a lot of effort. Maybe the package.json can just expand dependency of react as ^16.0.0 || ^17.0.0

Thanks!

[makopch-ms]

@loyalchow Can you help here?

[luisVelasquezSauce]

Hi @GiriB @makopch-ms we are looking into this ATM. But will add should support for React 17.

[GiriB]

Hey @luisVelasquezSauce! Do we have an ETA for this work? That will help us plan work on our end too. Thanks!

[luisVelasquezSauce]

Hello @GiriB, we do not have an ETA but would be very helpful if you can help us understand your need to update the dependency to react 17. We have tried the screener-storybook dependency with React 17 without changing the dependencies of screener-storybook and we haven't run into any issues. If we understand the need we can try to get this prioritized. Thanks

[sunilsurana]

All our projects are using React 17 so we would like to stay consistent across everything. There are multiple benefits we gain by keeping react version same across repo.

[GiriB]

@luisVelasquezSauce +1 to what @sunilsurana said. I think since React 17 doesn't have any breaking API change since React 16, you may have not run into any issue while using them together. But even then, the right thing is to officially update the package.json to mention that screener-storybook can work with React 17 components as well.

[luishernandezv]

Hi @GiriB @sunilsurana we have published a beta version 0.0.23-beta.1 with the updated dependencies, please give it a try and let me know how it goes.

[sunilsurana]

Thank you @luishernandezv

[sauce-tartar]

Going to close this, we are testing with React 17 routinely with Storybook 6.4+

If you're still having trouble @sunilsurana we can re-open. We also have a 1.0.0 alpha that has additional upgrading.