Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creep.room can literally never be undefined but types say it can be #99

Closed
lf- opened this issue Feb 12, 2017 · 2 comments
Closed

creep.room can literally never be undefined but types say it can be #99

lf- opened this issue Feb 12, 2017 · 2 comments

Comments

@lf-
Copy link
Contributor

lf- commented Feb 12, 2017

If the creep exists, it can see the room it's in. Unfortunately, the types don't reflect this and accesses without guards will cause TS errors.
@Dessix
Copy link
Collaborator

Dessix commented Feb 12, 2017

Feel free to PR.

@lf- lf- mentioned this issue Feb 12, 2017
Merged
@lf-
Copy link
Contributor Author

lf- commented Feb 12, 2017

PR up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dessix @lf-