Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Define range key if present #13

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Define range key if present #13

merged 1 commit into from
Sep 14, 2016

Conversation

FenrirUnbound
Copy link
Contributor

@FenrirUnbound FenrirUnbound commented Sep 14, 2016

DynamoDB requires that a primary sort key (in this case, keyRange) be defined so that you can sort your query.

This change is to configure & set up a table with a primary sort key if present in the schema.

Contingent on screwdriver-cd/data-schema#50

Solves screwdriver-cd/screwdriver#187

Copy link
Contributor

@stjohnjohnson stjohnjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable! Link to more about rangeKeys: https://www.npmjs.com/package/vogels#define-a-model

Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable to me 👍

@tkyi tkyi merged commit d62d3d9 into master Sep 14, 2016
@tkyi tkyi deleted the primary-range-key branch September 14, 2016 20:16
@d2lam
Copy link
Member

d2lam commented Sep 14, 2016

👍 adorable-creative-funn-ebb14MiBdNene

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants