fix: actually calls addWebhook function #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2lam
force-pushed
the
webhookbug
branch
2 times, most recently
from
aee9675
to
3cbd5cc
Compare
This was referenced Dec 20, 2016
| @@ -55,7 +55,7 @@ class ScmBase { | |||
| */ | |||
| addWebhook(config) { | |||
| return validate(config, dataSchema.plugins.scm.addWebhook) | |||
| .then(this._addWebhook); | |||
There was a problem hiding this comment.
This should not be needed because validate passes config.
There was a problem hiding this comment.
Ahh, it's because it loses this context internally.
petey
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After screwdriver-cd/data-schema#100 is merged, will get
TypeError: Cannot read property 'lookupScmUri' of undefinedbecause of this bug.Related: screwdriver-cd/screwdriver#379
Blocked by: screwdriver-cd/data-schema#100