Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1079): Remove unnecessary autoDeployKeyGenerationEnabled function #168

Merged
merged 6 commits into from Aug 5, 2020
Merged

fix(1079): Remove unnecessary autoDeployKeyGenerationEnabled function #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3036f5
feat(scm-github): Add key pair generation method and push pub key to scm
supra08 Jun 29, 2020
fb80832
feat(scm-github): Add key pair generation method and push pub key to scm
supra08 Jun 29, 2020
a583ce2
feat(): add accessor function for checking autoDeployKeyGeneration
supra08 Jul 16, 2020
9978ffc
feat(scm-github): add tests for addDeployKey and checkAutoDeployKeyGe…
supra08 Jul 16, 2020
6d3e33c
refactor(): change function names and localize constants
supra08 Jul 23, 2020
183e8c3
refactor(): use object destructing in config and use maps
supra08 Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions index.js
View file
Open in desktop
Expand Up @@ -372,15 +372,6 @@ class GithubScm extends Scm {
}
}

/**
* Returns whether auto deploy key generation is enabled or not
* @async _autoDeployKeyGenerationEnabled
* @return {Boolean} Resolves to the private key string
*/
async _autoDeployKeyGenerationEnabled() {
return this.config.autoDeployKeyGeneration;
}

/**
* Look up a webhook from a repo
* @async _findWebhook
Expand Down
8 changes: 0 additions & 8 deletions test/index.test.js
View file
Open in desktop
Expand Up @@ -1954,14 +1954,6 @@ jobs:
});
});

describe('autoDeployKeyGenerationEnabled', () => {
it('returns a boolean check', () =>
scm.autoDeployKeyGenerationEnabled().then((check) => {
assert.isBoolean(check);
})
);
});

describe('getBellConfiguration', () => {
it('returns a default configuration', () => (
scm.getBellConfiguration().then((config) => {
Expand Down