-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCM Branch-specific jobs #1082
Comments
I have split up the work into these tasks for now:
2018/06/12
2018/09/25
|
To get pipelines which you start jobs, I will add function to scm repositories which get branches from scms api. The flow is as below
|
@yuichi10 What's the use case for branch specific workflows ? Can't user specify branch while creating pipeline ? |
Yes, user can create specify branch pipeline. But, if user can manage multi branch by one pipeline, it makes easy to manage project by git-flow. |
This behavior seems reasonable to me @jithin1987 ^^ |
@yuichi10 Your proposal sounds reasonable to me. So the rules would be:
|
It seems to be that (2) makes the most intuitive sense. From a developer's perspective, when I specify In (1) there is also an implicit assumption that
|
👍 Sounds good to me. |
Thank you for your comments! tkyi's explain is easy to understand!
I agree with Filbird's opinion. If developer want to run whenever not pipeline's job, they need to use remote requires. Thank you guys again! |
@yuichi10 Hi Yuichi, I noticed that we're only adding the branch trigger for |
@minz1027 Hi minz, thank you for your notice. |
@minz1027 To me, How about to use same way as I think we can develop commit and pr functions separately, thus after this commit specific branch is finished, develop ~pr function. |
I found a bug of my implementation. When restart a job, Screwdriver try to build in the same way as previous, and get screwdriver.yaml from the It will be not good to refer other branch screwdriver.yaml. How do you think to resolve this problem? Are there any good way to fix this problem? |
Maybe I can fix this problem by using |
Hm so if I understand correctly, you are saying: |
Yes! So I think need to preserve the branch |
@jithin1987 |
@catto yes, we should have the same behavior. We do get some asks about relaxing this restriction, however in my opinion it should be based on a configuration. For now, lets prevent the further job triggers. |
@jithin1987 @catto having it based on SD configuration would mean letting PR jobs to trigger next jobs instead of preventing it...as outlined in #1010 . |
yes, doing it behind SD config will solve it. |
@jithin1987 cool, is that feature on the horizon? |
Context
The issue of #723 was closed but SCM Branch-specific jobs workflow is not implemented yet.
The workflow will make ease to use git flow.
Objective
Allow to specify branch to commit trigger.
Related links
Documentation: https://github.com/screwdriver-cd/screwdriver/blob/master/design/workflow.md#scm-branch-specific-jobs
Related to: #723
The text was updated successfully, but these errors were encountered: