feat(1082): [13] [small] fix to enable branch specific pr trigger #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk3fftk
reviewed
Jul 19, 2018
lib/getNextJobs.js
Outdated
| const triggerBranch = config.trigger.match(triggerBranchRegExp); | ||
|
|
||
| if (triggerBranch) { | ||
| if (triggerBranch[1].match(edgeSrcBranch[1])) { | ||
| if (triggerBranch && triggerBranch[1] === edgeSrcBranch[1]) { |
There was a problem hiding this comment.
These looks magic number so I think we should add some comments.
There was a problem hiding this comment.
Thanks, I added some comments.
yokawara
force-pushed
the
pr-branch-filter
branch
from
402dd85
to
716d3cf
Compare
yokawara
force-pushed
the
pr-branch-filter
branch
from
716d3cf
to
4064ed8
Compare
tkyi
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The branch specific trigger for
~pris not implemented yet.Objective
~prjobsReferences