feat(1415): Add logic to handle webhook events from external repos #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supra08
changed the title
pritamstyz4ever
previously approved these changes
Aug 25, 2020
jithine
reviewed
Aug 27, 2020
plugins/webhooks/index.js
Outdated
|
|
||
| const pipelines = await pipelineFactory.list(listConfig); | ||
|
|
||
| const pipelinesWithSubscribedExtRepos = await pipelineFactory.list(externalRepoSearchConfig); |
There was a problem hiding this comment.
we can call this pipelinesWithSubscribedRepos
plugins/webhooks/index.js
Outdated
| @@ -385,6 +394,15 @@ async function createPREvents(options, request) { | |||
| chainPR | |||
| }); | |||
|
|
|||
| let subscribedEvent = false; | |||
There was a problem hiding this comment.
don't you need similar changed in createEvents function ? This function is called only for PR events
There was a problem hiding this comment.
yeah they are coming up as further additions. This was just a work in progress.
supra08
force-pushed
the
external-scms
branch
2 times, most recently
from
9c6d349
to
4eca0cc
Compare
tkyi
reviewed
Sep 3, 2020
tkyi
reviewed
Sep 3, 2020
tkyi
reviewed
Sep 3, 2020
tkyi
reviewed
Sep 3, 2020
tkyi
reviewed
Sep 4, 2020
supra08
force-pushed
the
external-scms
branch
from
2cdec45
to
3d784f8
Compare
tkyi
reviewed
Oct 8, 2020
| if (b === branch) { | ||
| eventConfig.startFrom = '~pr'; | ||
| } | ||
|
|
||
| // Check if the webhook event is from a subscribed repo and | ||
| // set the jobs entrypoint from ~startfrom | ||
| // For subscribed PR event, it should be mimiced as a commit |
There was a problem hiding this comment.
what does this mean? should this be type: 'pr'?
There was a problem hiding this comment.
pr event happened on the subscribed git repo. But for the subscriber it's similar to running a commit event
jithine
approved these changes
Oct 12, 2020
tkyi
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #1415
Objective
This PR adds logic to webhook endpoint to handle notifications from external repos. First it filters the triggered pipelines with the checkoutUrl from the incoming request. Here it utilizes the newly added
containsoperator for querying. After that it is checked whether the request is from an external repo or not and based on that sends a flag to the EventFactory module to handle them likewise.References
#1415
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.