fix(1415): models@v28.3.0 #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshwata
previously approved these changes
Oct 13, 2020
|
Should we also change these webhook methods? screwdriver/plugins/pipelines/update.js Line 143 in e3febff |
kumada626
approved these changes
Oct 13, 2020
DekusDenial
approved these changes
Oct 13, 2020
tkyi
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm getting an error
data: TypeError: pipeline.addWebhook is not a functionwhen creating the pipeline.Due to the following PR in models@v23.3.0,
addWebhookis now changed toaddWebhooks.https://github.com/screwdriver-cd/models/pull/472/files#diff-2977a16e13f278992ce964024e936111d8f1c3b68f5f698c7e06195258912721L383-R384
Objective
I want pass test step.
https://cd.screwdriver.cd/pipelines/1/builds/577559/steps/test
References
screwdriver-cd/models#472
Related to #1415
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.