fix(2980): remote trigger does not work when the job includes other normal join jobs [2] #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk634
changed the title
y-oksaku
approved these changes
Jan 30, 2024
kumada626
approved these changes
Jan 30, 2024
tkyi
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If a Remote Triggered downstream pipeline was Remote Triggered twice, only one job would be triggered.
Reference: #2980.
Due to this issue, #2964 was reverted.
I would like to change the #2964 again with this issue resolved.
Objective
As mentioned in #2980 (comment), the problem is that the loop would return, so we will fix it so that it triggers all necessary builds without returning.
References
The unit test fails until screwdriver-cd/workflow-parser#49 is published.
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.