feat: add check for enterprise github cloud #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Mar 25, 2024
plugins/auth/index.js
Outdated
Comment on lines
74
to
75
| gheCloud: joi.boolean().optional().default(false), | ||
| gheCloudSlug: joi.string().optional() |
There was a problem hiding this comment.
do you need to update https://github.com/screwdriver-cd/screwdriver/tree/master/config?
There was a problem hiding this comment.
oh yes, on it
There was a problem hiding this comment.
updated to encapsulate config under scm
tkyi
previously approved these changes
Mar 25, 2024
tkyi
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need a mechanism to identify if a user belongs to an enterprise when using the Github Enterprise Cloud configuration for login
Objective
This PR adds configuration to check if the user belongs to the enterprise github cloud
References
screwdriver-cd/scm-github#224
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.