fix: Add sha filter for pipeline events #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VonnyJap
reviewed
Apr 8, 2024
plugins/pipelines/listEvents.js
Outdated
| field: ['sha', 'configPipelineSha'], | ||
| // Do a fuzzy search for sha | ||
| // See https://www.w3schools.com/sql/sql_like.asp for syntax | ||
| keyword: `%${sha}%` |
There was a problem hiding this comment.
Suggested change
| keyword: `%${sha}%` | |
| keyword: `${sha}%` |
There was a problem hiding this comment.
☝️ to support short and full SHA.
VonnyJap
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It would be nice for users to be able to filter events by commit SHA.
Objective
This PR adds query param to filter by sha for pipeline events.
References
N/A
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.