fix(3012): Trigger remote join job in restart when the last remote join job is successful #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-oksaku
reviewed
Jun 6, 2024
y-oksaku
reviewed
Jun 6, 2024
Co-authored-by: y-oksaku <43719835+y-oksaku@users.noreply.github.com>
Co-authored-by: y-oksaku <43719835+y-oksaku@users.noreply.github.com>
y-oksaku
approved these changes
Jun 6, 2024
tkyi
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Followup this PR
#3122
Remote Join job should be triggered on the new event on upstream when restart from an event downstream of the event in which Remote Join is successful.
However, the event and build are created but not triggered.
Objective
Fix the function call location so that the build can be fetched and triggered from the new event that was created.
In addition, add a test for this scenario. (In other words, make sure that it is triggered twice in total by start and restart)
References
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.