fix: fix pkg version #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuichi10
reviewed
Dec 4, 2018
hab/hab_test.go
Outdated
| RangeEnd: 0, | ||
| TotalCount: 0, | ||
| PackageList: []PackageInfo{}, | ||
| }, |
There was a problem hiding this comment.
PackagesInfo's last } indent looks strange.
sakka2
approved these changes
Dec 4, 2018
d2lam
approved these changes
Dec 5, 2018
|
Thank you! Please re-enable functional test in API when ready. I disabled it previously: screwdriver-cd/screwdriver#1404 |
This was referenced Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sd-stepfailed withpkg-versionoption in some cases.I think the habitat API is something strange.
https://willem.habitat.sh/v1/depot/pkgs/core/node?range=0
https://willem.habitat.sh/v1/depot/pkgs/core/node?range=23
Previously, it may returns
total_countwhich is the number of whole packages,but now it may be the number of the packages in a page.
And some pages may contains same contents?
This PR fixed to work with the current API behavior for now.
But this fix may be just workaround.
I confirm in local environment.