feat(926): Display template namespace if it exists #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithine
reviewed
Jun 1, 2018
app/templates/index/route.js
Outdated
| @@ -12,6 +12,12 @@ export default Route.extend({ | |||
| templates.forEach((t) => { | |||
| if (!names[t.name]) { | |||
| names[t.name] = 1; | |||
| // construct full template name | |||
| t.fullName = t.name; | |||
There was a problem hiding this comment.
can we define this in a common place, second time this logic is repeated.
jithine
reviewed
Jun 1, 2018
| @@ -1,8 +1,8 @@ | |||
| <article class="template"> | |||
| <header> | |||
| {{#link-to "templates.detail" template.name}}<h4>{{template.name}}</h4>{{/link-to}} | |||
| {{#link-to "templates.detail" template.fullName}}<h4>{{template.fullName}}</h4>{{/link-to}} | |||
jithine
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Should display namespace/name if namespace exists and is not "default". Also showing namespace and name in the template detail page now.
Objective
This PR should fix it so it still shows namespace and name.
Example with namespace:
Example with default namespace:
Related links
Related to screwdriver-cd/screwdriver#926