fix: make dashboard/show page fetch pipeline metrics #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need some test changes |
adong
requested changes
Oct 14, 2019
|
By the way, can you check out from master for new feature developments? We see lots of out dated micro commits.. |
okay |
Code-Beast
force-pushed
the
yufeng-default-collection
branch
from
f219e33
to
9849f56
Compare
…nsive to window resize
Code-Beast
force-pushed
the
yufeng-default-collection
branch
from
9849f56
to
1b063ba
Compare
adong
approved these changes
Oct 16, 2019
jithine
approved these changes
Oct 16, 2019
adong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently the dashboard/show page fetches metrics of last month, which may retrieve nothing for some pipeline that hasn't been triggered for a while and cause pipeline-card component or collection-table-row component to show nothing (because lastEventInfo will be empty too). If we fetch pipeline metrics by pagination, we can always get the latest metrics info as long as the pipeline has been triggered before.
Besides, the dashboard/show page is not responsive enough currently.
Objective
References
Screwdriver-1784
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.