Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1082):[5] Check the trigger does match the regex or not #12

Merged
merged 3 commits into from
Jun 8, 2018

Conversation

kumada626
Copy link
Contributor

Context

To trigger from specific branch commit, getNextJobs allow regex when check edge.src and config.trigger.

Objective

Use edge.src as a regex and check the trigger does match the regex or not.

References

Related to: screwdriver-cd/screwdriver#1082

Copy link

@yuichi10 yuichi10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumada626 kumada626 changed the title feat(1082): Check the trigger does match the regex or not [WIP][DNM]feat(1082): Check the trigger does match the regex or not May 29, 2018
@kumada626 kumada626 changed the title [WIP][DNM]feat(1082): Check the trigger does match the regex or not feat(1082): Check the trigger does match the regex or not Jun 1, 2018
@kumada626
Copy link
Contributor Author

Fixed check trigger regexp method corresponding to screwdriver-cd/screwdriver#1092 .

Copy link
Contributor

@yokawara yokawara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakka2
Copy link
Contributor

sakka2 commented Jun 4, 2018

LGTM!

@kumada626 kumada626 changed the title feat(1082): Check the trigger does match the regex or not feat(1082):[5] Check the trigger does match the regex or not Jun 5, 2018
Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help to have some comments around your logic, but otherwise LGTM 👍

Copy link
Member

@tk3fftk tk3fftk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@minzcmu minzcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkyi tkyi merged commit 2c065c6 into screwdriver-cd:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants