Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks and checks to the project #137

Closed
2 tasks done
andrewtavis opened this issue Jun 1, 2024 · 4 comments
Closed
2 tasks done

Add pre-commit hooks and checks to the project #137

andrewtavis opened this issue Jun 1, 2024 · 4 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue would focus on adding in pre-commit to Scribe-Data such that linting, formatting and other checks could be ran on commit to avoid them being sent to the repo. Directions on how to setup pre-commit would further need to be added to the readme and contributing guide :)

Contribution

Would be happy to support or get to this as I can! This would also be a good first issue for someone who has some Python experience or experience setting up pre-commit 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 1, 2024
@kush34
Copy link
Contributor

kush34 commented Jun 1, 2024

Hey, this looks easy, I am working on this. can I ask if any help is needed?

@andrewtavis
Copy link
Member Author

Hey @kush34 👋 Sure thing! Happy to help if you need :) You can checkout the pre-commit config file for another project I work on here. Generally the thing to do is use pre-commit sample-config > .pre-commit-config.yaml that'll give us the file, and then from there we can add in the ruff hooks that are in the config file I linked. From there pre-commit install, and then we know it works with pre-commit run --all-files 😊

@andrewtavis
Copy link
Member Author

You'd also be welcome to pick up the other issue we have for this - scribe-org/Scribe-iOS#450 - once this one is finished!

@kush34 kush34 mentioned this issue Jun 4, 2024
1 task
@andrewtavis
Copy link
Member Author

Closed via #141 :) Thanks for the help here, @kush34! Feel free to write in scribe-org/Scribe-iOS#450 if you have interest in working on that one as well 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants