-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docker-compose.yaml #13
base: main
Are you sure you want to change the base?
Create docker-compose.yaml #13
Conversation
Created a docker-compose.yaml file
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things I noticed, @henrikth93
but thank you for looking into this! 🚀
volumes: | ||
- testvolume:/home/scribe-server/volume | ||
image: mariadb | ||
environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be good to also set here the following environment variables:
MARIADB_USER
MARIADB_PASSWORD
MARIADB_DATABASE
I believe that would also create a new test database already with credentials within the container when the stack is spun up. We could then test if Scribe-Server is able to connect with the credentials here.
Co-authored-by: Will Yoshida <15043193+wkyoshida@users.noreply.github.com>
Added MARIADN_USER to the file.
Created a docker-compose.yaml file
Contributor checklist
Description
Related issue