Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose.yaml #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

henrikth93
Copy link
Collaborator

@henrikth93 henrikth93 commented Feb 25, 2024

Created a docker-compose.yaml file

Contributor checklist


Description

Related issue

Created a docker-compose.yaml file
Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@wkyoshida wkyoshida self-requested a review February 25, 2024 22:27
Copy link
Member

@wkyoshida wkyoshida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things I noticed, @henrikth93
but thank you for looking into this! 🚀

docker-compose.yaml Outdated Show resolved Hide resolved
volumes:
- testvolume:/home/scribe-server/volume
image: mariadb
environment:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to also set here the following environment variables:

  • MARIADB_USER
  • MARIADB_PASSWORD
  • MARIADB_DATABASE

I believe that would also create a new test database already with credentials within the container when the stack is spun up. We could then test if Scribe-Server is able to connect with the credentials here.

henrikth93 and others added 3 commits June 18, 2024 22:01
Co-authored-by: Will Yoshida <15043193+wkyoshida@users.noreply.github.com>
Added MARIADN_USER to the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants