UILexicon not loading into keyboard via expandLanguageDataset()

[andrewtavis]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-iOS' Code of Conduct

Behavior

The first bug in v2.2.0 is that it appears that expandLanguageDataset() isn't being called. What this means is that the user doesn't have access to all that was being added via this function call: specifically UILexicon names, the word Scribe so that it can trigger the easter egg 🐰🐣😢, and German compound prepositions.

The point in the app where this should be called is the following:

Scribe-iOS/Keyboards/KeyboardsBase/KeyboardViewController.swift

Line 1470 in 1b39705

expandLanguageDataset()

The issue is that as of now I cannot reproduce this on a simulator... A fix for this should definitely be included in a future release :)

Device type

iPhone and iPad

Versions

v2.2.0

[andrewtavis]

Note that the following Scribe-Data issues will handle parts of this issue such that in the end the focus will just be the UILexicon not being included:

• Add German compound prepositions to data process Scribe-Data#34
• Add "Scribe" to the data process Scribe-Data#35

[andrewtavis]

As the above specified Scribe-Data issues are done, the focus of this issue is now solely on the UILexicon not being present :)

[Taufi]

I could take care of that. The problem seems to be that we are not allowed to write to files or databases on the app's main bundle. The simulator seems to allow it, but not the device.

[andrewtavis]

Would be great to get some help with this, @Taufi! Thank you for offering :) Let us know if there's anything we can do to help 😊

[Taufi]

Andrew, I was just about to make the pull request for the issue. Before that, I fetched the latest changes from upstream. This version ran into an error in Scripe>ParentTableCellModel from commit "b8cef23“. The init function does not work when setting the property hasNestedNavigation. The commit is from you, so the question is whether you can help?

[andrewtavis]

Hey @Taufi 👋 It looks like I mistakenly removed self from self.hasNestedNavigation = hasNestedNavigation? Change should go in ParentTableCellModel.swift.

[andrewtavis]

Do you want to add this as a minor fix to your PR?

[Taufi]

Yes, with pleasure. Thanks for the tip.

[andrewtavis]

Thanks for the fix, and sorry it was needed!

[andrewtavis]

Closed via #420 🥳 I was seeing Appleseed as an autocomplete option across keyboards, and here's hoping we'll see it once v3.0 is live. Assuming we will 😊

Thanks @Taufi!