Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent command bar outline behavior #423

Closed
2 tasks done
andrewtavis opened this issue May 16, 2024 · 13 comments
Closed
2 tasks done

Inconsistent command bar outline behavior #423

andrewtavis opened this issue May 16, 2024 · 13 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 16, 2024

Terms

Behavior

Something that was discussed in #416 is that we're at times seeing inconsistent borders around the command bar. The following is from an iPhone 15 Pro simulator:

image

And the following is from an iPhone 15.2 Pro simulator:

Screenshot 2024-05-07 at 3 19 09 PM

In the above, the shadows are darker under the buttons, and the border around the command bar is also darker. One way to improve this a bit would be to remove the border around the command bar on light mode, as the shadow is providing enough contrast (is needed on dark mode though).

Open to discussions on this and working with people on it!

Device type

iPhone

Versions

Current main version

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed labels May 16, 2024
@andrewtavis
Copy link
Member Author

CC @Jag-Marcel and @fabulouiOS-monk 😊 Let me know on the idea of removing the border around the command bar! Happy to get suggestions on what's up with the shadows as well :)

@fabulouiOS-monk
Copy link
Contributor

Hi @andrewtavis, I did some work on it and here are the Screenshots with the code updates:
Removed shadow from below the bar

In Dark mode:
noShadow-Dark

In Light mode:
noShadow-Light

@fabulouiOS-monk
Copy link
Contributor

If all good from your side I can raise PR for it.

@andrewtavis
Copy link
Member Author

Thanks for looking into this, @fabulouiOS-monk :) Looking at it, I think that having the shadow still would be important, but maybe we can try removing the border from the command bar and Scribe key in light mode? Maybe the contrast is enough to also work in dark mode, but let's check in light mode first 😊

@andrewtavis
Copy link
Member Author

Assigning you as we're working on this, @fabulouiOS-monk :)

@fabulouiOS-monk
Copy link
Contributor

fabulouiOS-monk commented May 17, 2024

Sure, thank you will look into it.

Things I will be looking into:

  1. Remove border.
  2. How it looks in Light and Dark Mode.
  3. Keeping some shadow.

@andrewtavis
Copy link
Member Author

Thanks for the repeat to check our understanding, @fabulouiOS-monk! All sounds good, and looking forward to seeing what you find out 😊

@fabulouiOS-monk
Copy link
Contributor

@andrewtavis, Here are the Screenshots with the border removed and the shadow kept as it is:

Dark mode (I think the contrast is enough to make the difference):
withoutBorder-dark

Light mode:
withoutBorder-light

P.S: Took time since working this with my regular job ;)

@fabulouiOS-monk
Copy link
Contributor

@andrewtavis, So do we need to update it or let it be?

@andrewtavis
Copy link
Member Author

Hey @fabulouiOS-monk 👋 Have been at work :) I think we're good for a PR so I can play around with it myself and see 😊 Thanks for the work till now!

@fabulouiOS-monk
Copy link
Contributor

Hey @andrewtavis, Thank you, I raised the PR!

@andrewtavis
Copy link
Member Author

Thanks, @fabulouiOS-monk! I'll try to get to it this weekend with the other PR :) :)

@andrewtavis
Copy link
Member Author

Closed via #438 🚀 Thanks so much for the conversation here and the changes, @fabulouiOS-monk! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants