Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftLint: Fix trailing_whitespace throughout codebase #429

Closed
2 tasks done
andrewtavis opened this issue May 16, 2024 · 3 comments
Closed
2 tasks done

SwiftLint: Fix trailing_whitespace throughout codebase #429

andrewtavis opened this issue May 16, 2024 · 3 comments
Assignees
@mostazomarc
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 16, 2024 •
edited
Loading

Terms

Description

Work for this issue would remove trailing_whitespace as a disabled rule from .swiftlint.yml and fix all errors for it in the codebase.

Docs for trailing_whitespace are here: https://realm.github.io/SwiftLint/trailing_whitespace.html

We'd know that this is successful if our SwiftLint pull request workflow passes on the pull request for the change 🚀

Contribution

This would be a great good first issue for someone wanting to start with Scribe-iOS development. Happy to support! 😊
@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 16, 2024
@mostazomarc
Copy link
Contributor

I'll be working on it!

mostazomarc added a commit to mostazomarc/Scribe-iOS that referenced this issue May 17, 2024
@mostazomarc
scribe-org#429 removed trailing_whitespace from disabled rules in .sw…
a790938 
…iftlint.yml
@mostazomarc mostazomarc mentioned this issue May 17, 2024
Merged
1 task
@andrewtavis
Copy link
Member Author

Thanks, @mostazomarc! :)

andrewtavis added a commit that referenced this issue May 17, 2024
@andrewtavis
Merge pull request #435 from mostazomarc/429-fix-trailing-whitespace
5a62598 
#429 removed trailing_whitespace from disabled rules in .swiftlint.yml
andrewtavis added a commit that referenced this issue May 17, 2024
@andrewtavis
#429 update changelog with changes for removed whitespace
decd8a6
@andrewtavis
Copy link
Member Author

Closed by #435. Appreciate the quick work here, @mostazomarc! Happy to work on another linting error, or let me know if something else sounds interesting 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostazomarc mostazomarc

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @mostazomarc