Fix color mode attribution for app in dark mode

[andrewtavis]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-iOS' Code of Conduct

Behavior

We currently are assigning colors inconsistently in the application in dark mode.

When we start the app we have the correct colors for the install screen background and the tab bar as seen here:

Switching to Settings, the tab bar and menu options now have a more grey color:

On About the tab bar is colored again ok, but the chevron menu options have the wrong color:

And if we switch to the installation from settings we get a more grey tab bar (it's correctly black if we switch from About):

Would be great to get some help with this, and I'd be very happy to support!

Device type

iPhone and iPad

Versions

Current main version

[andrewtavis]

From the sync: on launch it's taking the color from the storyboard, and then within the code it's being set to a different color.

[andrewtavis]

@SaurabhJamadagni, I decided that it made sense for me to work on it as a precursor to working on #351 :) 1998974 sends along all the changes except for the settings screen, so almost done!

[andrewtavis]

Note on this: the discoloration is actually not dark mode based. There's an grey/black with a very low alpha being applied above the cells and the tab bar. So far finding them and settings their colors explicitly is working. I've also set the color of the tab bar explicitly to white and black, but then on the settings page it's still getting the light alpha over it and then on the installation page it persists if the user switches from the settings page (still not happening on About).

[andrewtavis]

Removing translucent from the tab bar properties fixes it 🥳 Last thing for the color mode is to fix the link color attributions. It looks like the light mode and dark mode colors are being applied in an opposite manner 🤔 Maybe this is related to the tab bar colors where the Scribe Blue that's displayed is the opposite one for the color mode 🤔

[andrewtavis]

Closed by the above commits 🥳 Thanks for the chat about this in the sync, @SaurabhJamadagni, and hope it's ok that I stepped in! 😊