-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a static menu and necessary components #324
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
889d7d6
feat: adding tab bar and work on about section
SaurabhJamadagni 12454fa
design: testing how to work with table views for about section
SaurabhJamadagni 2dae15f
working with segue to next view
SaurabhJamadagni 6df5a1e
adding information cell xib to reuse cells
SaurabhJamadagni a4c60a9
loading about section data into table cells
SaurabhJamadagni 0000c32
getting scroll view to work in about page
SaurabhJamadagni 840cd32
intermediate commit to redo about screen
SaurabhJamadagni 1e17632
Redoing the About section using nested table views.
SaurabhJamadagni 89c4afa
Adding Settings tab cell data and reorganising files
SaurabhJamadagni 0bbe28c
parent cell model and settings table data
SaurabhJamadagni aafe286
docs: CHANGELOG update
SaurabhJamadagni e35bab7
adding a toggle element to the child cell that can be displayed inste…
SaurabhJamadagni b497a2b
Add contributing note to readme and guidelines
andrewtavis 50c1c59
fix: Tables align with page title
SaurabhJamadagni 24bd479
fix: padding between cell icon and label
SaurabhJamadagni a25c0bf
fix: increasing cell height and disabling scroll inside child tables
SaurabhJamadagni f2f1b64
Merge branch 'main' into gsoc23-menu
andrewtavis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // | ||
| // AboutTableData.swift | ||
| // Scribe | ||
| // | ||
| // Created by Saurabh Jamadagni on 05/06/23. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct AboutTableData { | ||
| static var aboutTableData = [ | ||
| ParentTableCellModel( | ||
| headingTitle: "Community", | ||
| section: [ | ||
| Section(sectionTitle: "See the code on GitHub", imageString: "github", hasToggle: false), | ||
| Section(sectionTitle: "Chat with the team on Matrix", imageString: "matrix", hasToggle: false), | ||
| Section(sectionTitle: "Wikimedia and Scribe", imageString: "wikimedia", hasToggle: false), | ||
| Section(sectionTitle: "Share Scribe", imageString: "square.and.arrow.up", hasToggle: false) | ||
| ] | ||
| ), | ||
| ParentTableCellModel( | ||
| headingTitle: "Feedback and support", | ||
| section: [ | ||
| Section(sectionTitle: "Rate Scribe", imageString: "star", hasToggle: false), | ||
| Section(sectionTitle: "Report a bug", imageString: "ant", hasToggle: false), | ||
| Section(sectionTitle: "Send us an email", imageString: "envelope", hasToggle: false), | ||
| Section(sectionTitle: "Reset app hints", imageString: "lightbulb", hasToggle: false) | ||
| ] | ||
| ), | ||
| ParentTableCellModel( | ||
| headingTitle: "Legal", | ||
| section: [ | ||
| Section(sectionTitle: "Privacy policy", imageString: "lock.shield", hasToggle: false), | ||
| Section(sectionTitle: "Third-party licenses", imageString: "thirdPartyLicenses", hasToggle: false) | ||
| ] | ||
| ) | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // | ||
| // AboutViewController.swift | ||
| // Scribe | ||
| // | ||
| // Created by Saurabh Jamadagni on 29/05/23. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| class AboutViewController: UIViewController { | ||
|
|
||
| @IBOutlet weak var outerTable: UITableView! | ||
|
|
||
| let tableData = AboutTableData.aboutTableData | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| self.title = "About Scribe" | ||
|
|
||
| let nib = UINib(nibName: "ParentTableViewCell", bundle: nil) | ||
| outerTable.register(nib, forCellReuseIdentifier: "ParentTableViewCell") | ||
|
|
||
| outerTable.dataSource = self | ||
| outerTable.delegate = self | ||
|
|
||
| outerTable.separatorStyle = .none | ||
| outerTable.backgroundColor = .clear | ||
| } | ||
| } | ||
|
|
||
|
|
||
| // MARK: UITableViewDataSource | ||
| /// Function implementation conforming to the UITableViewDataSource protocol. | ||
| extension AboutViewController: UITableViewDataSource { | ||
| func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { | ||
| return tableData.count | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
|
|
||
| let cell = tableView.dequeueReusableCell(withIdentifier: "ParentTableViewCell", for: indexPath) as! ParentTableViewCell | ||
|
|
||
| cell.configureCell(for: tableData[indexPath.row]) | ||
|
|
||
| cell.backgroundColor = .clear | ||
| cell.selectionStyle = .none | ||
|
|
||
| return cell | ||
| } | ||
| } | ||
|
|
||
| // MARK: UITableViewDelegate | ||
| /// Function implementation conforming to the UITableViewDelegate protocol. | ||
| extension AboutViewController: UITableViewDelegate { } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
52 changes: 52 additions & 0 deletions
52
Scribe/Assets.xcassets/MenuIcons/github.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "github.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "filename" : "github-dark.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey hey 👋
Would texts like these, the
sectionTitles here, be good candidates for i18n? I see some support for it started already under./Scribe/AppTexts. Thinking that the app texts here could be good ways as well to continue working i18n into Scribe.Implementing via the below perhaps?