Fixes #380: Code quality improvement by replacing while with for loop

[kevin9foong]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

I have made a simple refactoring of the code to replace while with for loop as suggested previously by @flumaves.
In order to replace the logic for i+=1 due to the allowUndo if clause, I have used the continue keyword to skip to 0th indexed element in the event allowUndo evaluates to true.

Testing code works:

I have verified the new changes retain the same behaviour as previously.

I have also run the app in the simulator to ensure the keyboard view works as expected as shown in the attached screenshot.

Related issue

• Fixes Improper use of while loop #380

Please let me know if there are any changes for me to make. Hoping to be able to submit my first contribution to this project!

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[kevin9foong]

hi @andrewtavis, could you please give my PR a review when you have the time? Thank you!

[andrewtavis]

All looks good to me, @kevin9foong :) Appreciate the contribution 🥳 Would be nice to have you join the public Matrix community if it'd be of interest 😊