SlackJsonTokenExtractor handle null access_token #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: scribejava#1023 Slack does not always provide the bot access token, if you don't ask for those scopes. This Note - the underlying OAuth2AccessToken has a Precondition for "access_token can't be null", so here it is provided with an empty string.
peterp-canva
commented
Apr 28, 2022
| final JsonNode globalAccessToken = response.get(OAuthConstants.ACCESS_TOKEN); | ||
|
|
||
| return createToken( // | ||
| globalAccessToken == null ? "" : globalAccessToken.asText(), // Avoid "access_token can't be null" |
There was a problem hiding this comment.
Note - the underlying OAuth2AccessToken (for SlackOAuth2AccessToken->super()) has a Precondition for "access_token can't be null", so here it is provided with an empty string.
The tokenType will be null, so it is easy to deduce whether the string is meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1023
Slack does not always provide the bot access token, if you don't ask for those scopes.
Example:
&scope=&user_scope=users.profile%3Aread{"ok":true,"app_id":"AA","authed_user":{"id":"UID","scope":"channels:read,groups:read,users.profile:read,files:write:user","access_token":"xoxp-1234-etc","token_type":"user"},"team":{"id":"TId","name":"TeamName"},"enterprise":{"id":"EId","name":"EName"},"is_enterprise_install":false}Error - This leads to:
Solution:
Downgrade "access_token" to not be extractRequiredParameter, by overriding the implementation.
scribejava/scribejava-core/src/main/java/com/github/scribejava/core/extractors/OAuth2AccessTokenJsonExtractor.java
Line 90 in 9c8e4c1