Added DataportenApi #805
Merged
Added DataportenApi #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kullfar
reviewed
Dec 4, 2017
| } | ||
|
|
||
| @Override | ||
| public Verb getAccessTokenVerb() { |
There was a problem hiding this comment.
POST is default, no need to override
kullfar
reviewed
Dec 4, 2017
|
|
||
| @Override | ||
| public TokenExtractor<OAuth2AccessToken> getAccessTokenExtractor() { | ||
| return OAuth2AccessTokenJsonExtractor.instance(); |
|
@kullfar Do you want me to make the changes and do a new PR? |
|
No, changes are minor. I'll make changes myself while will be merging Pull Request to the master. |
|
I have replied. Since Dataporten is used by so many different organization it can be a little confusing, but you want the "Feide test users" listed under "Alternative login providers for non-educational users". |
|
well done, I have merged it to the master |
|
Thx again! |
|
Thank you good sir :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataporten is a national autentication provider in Norway used by many public companies and educational institusions.