scriptcs -debug without -repl does not configure REPL correctly.

[adamralph]

This is not new in 0.14. It is pre-existing in 0.13.3.

Leads to all kinds of problems, e.g.

mkdir bug-repro
cd bug-repro
scriptcs -install Nancy
scriptcs -debug
using Nancy;

Index was outside the bounds of the array.

Without -debug, there is no error.

[filipw]

The scriptcs -debug was intended to be used for PDB debugging not for log messages.
If you want debugging log in REPL you should:

• scriptcs -log debug
• scriptcs -debug -repl

Right now the ArgumentParser will not set the REPL flag if the only argument is debug.

[adamralph]

OK, well, we need to do something about the UX here then. To any user this will just appear as the bug I have described.

Shall we just prevent REPL when -debug is passed?

[filipw]

the easiest would be just treat single debug argument same way as single log argument - and force repl https://github.com/scriptcs/scriptcs/blob/dev/src/ScriptCs/Argument/ArgumentParser.cs#L30

[adamralph]

That line of code redundant, since the command factory now falls back to REPL when no script name is passed. This PR gets rid of it - #944

[adamralph]

...that is why scriptcs -debug works today and goes into REPL.

[adamralph]

In which case, I think the bug stands. Either we disable REPL when in debug mode, or we have to fix it.

[filipw]

but does it set the REPL flag? the flag is important since that's how the module chooses the appropriate engine.
In this case it doesnt set the engine properly - notice not only using doesn't work, but nothing works in that REPL since the debugger engine can't handle REPL at all.

[filipw]

here

scriptcs/src/ScriptCs.Engine.Roslyn/RoslynModule.cs

Line 16 in 09bb9af

engineType = config.IsRepl ? typeof(RoslynReplEngine) : engineType;

Right now this flag is missing, and everything fails. ArgumentParser sets it if the only argument is log for example

[adamralph]

Ah I see. Yes, that's the problem then.

[filipw]

can you make sure the PR in #944 handles this scenario?

[adamralph]

Yes, will do.

[adamralph]

@filipw PR #944 now addresses this