Improve BRD arena event #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the crowd of spectators will turn neutral once the arena event is defeated
| { | ||
| for (GuidSet::const_iterator itr = m_sArenaCrowdNpcGuids.begin(); itr != m_sArenaCrowdNpcGuids.end(); ++itr) | ||
| { | ||
| Creature* pSpectator = NULL; |
There was a problem hiding this comment.
Oops, that line should be moved above the for block... My mistake...
|
👍 |
| @@ -87,8 +96,20 @@ enum | |||
| SPELL_STONED = 10255, // Aura of Warbringer Constructs in Relict Vault | |||
|
|
|||
| FACTION_DWARF_HOSTILE = 754, // Hostile faction for the Tomb of the Seven dwarfs | |||
| FACTION_ARENA_NEUTRAL = 674, // Neutral faction for NPC in top of Arena after event complete | |||
There was a problem hiding this comment.
@Tobschinski provided me data a few minutes ago saying that faction should instead be 15 and not 674.
[25] UpdateType: Values
[25] Object Guid: Full: 0x1C16FC1CC008B000003A08000308899B Creature/0 R1471/S14856 Map: 230 Entry: 8896 Low: 50891163
[25] UNIT_FIELD_FACTIONTEMPLATE: 15
|
Looks good. |
|
Yup, this is pretty much what I had in mind. I haven't verified that those entries are correct, and I didn't check the cylinder data either, but I trust you on that. It's easy enough to tweak/adjust anyway. Good job, +1 from me too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the crowd of spectators will turn neutral once the arena event is defeated