This repository has been archived by the owner on Nov 10, 2018. It is now read-only.
docstring conform to PEP 484 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +144,7 @@ def get_config(name="root"): | |||
| of name `name`. | |||
|
|
|||
| Returns: | |||
| config (dict): By default scriptharness.structures.LoggingDict | |||
| config (Dict[str, str]): By default scriptharness.structures.LoggingDict | |||
There was a problem hiding this comment.
config doesn't have to have str values; they can be dicts, lists, strs, ints... maybe 'object' or 'various' or something?
Ah, looks like 'Any'.
|
Thank you, @carocad. I don't think any of the above comments strictly block, though a couple could be improved. The main concern I have is that we need to resolve conflicts before merging; could you address that? |
|
Hey Aki, I hope it helps ;) |
escapewindow
added a commit
that referenced
this pull request
Aug 18, 2015
docstring conform to PEP 484
|
Thank you Camilo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Aki,
I changed the old docstrings to conform to the new PEP. You should beware that since there was no fast way to contact you, most of the time I worked under my best assumption of the type of variable that you were expecting. This is specially strong on the dicts, where most of the type there were nested types which makes it difficult to keep track of them :/
Hope it helps