Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't parse multipart at all #15

Merged
merged 1 commit into from Jun 14, 2018
Merged

fix: don't parse multipart at all #15

merged 1 commit into from Jun 14, 2018

Conversation

ungoldman
Copy link
Contributor

@ungoldman ungoldman commented Jun 13, 2018 •
edited

changes

  • skip parseBody if content is not application/json
    • if it's multipart, request needs to be unmodified so parsers can read the stream (stream can only be read once)

version

patch

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 97.778% when pulling 5bc3dfe on ng/multipart2 into a36d3e0 on master.

@ungoldman ungoldman merged commit 7ffacf5 into master Jun 14, 2018
@ungoldman ungoldman deleted the ng/multipart2 branch June 14, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddself toddself toddself approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ungoldman @coveralls @toddself