Make NcipService extend EventEmitter

README.md

@@ -101,3 +101,13 @@ if ($request->is('LookupUser')) {
 }
 ```
 
+### Events:
+
+The client emits events on each request to the server. This can be useful to implement logging.
+The events are `request.item`, `request.user`, `request.checkout`, `request.checkin` and `request.renew`.
+
+```php
+$client->on('request.checkout', function($userId, $itemId) {
+	$log->addInfo('Requested checkout of item "' . $itemId . '" for user "' . $userId . '"');
+}
+```

src/Scriptotek/Ncip/NcipClient.php

@@ -7,25 +7,21 @@
  */
 
 use Danmichaelo\QuiteSimpleXMLElement\InvalidXMLException;
-use Evenement\EventEmitter;
 
 class NcipClient extends NcipService {
 
 	protected $connector;
 
-	protected $emitter;
-
 	/**
 	 * Create a new Ncip client
 	 *
 	 * @param  NcipConnector  $connector
 	 * @param  EventEmitter   $emitter
 	 * @return void
 	 */
-	public function __construct(NcipConnector $connector, EventEmitter $emitter = null)
+	public function __construct(NcipConnector $connector)
 	{
 		$this->connector = $connector;
-		$this->emitter = $emitter ?: new EventEmitter;
 		parent::__construct();
 	}
 
@@ -56,7 +52,7 @@ public function post(Request $request)
 	public function lookupUser($user_id)
 	{
 		$request = new UserRequest($user_id);
-		$this->emitter->emit('request.user', array($user_id));
+		$this->emit('request.user', array($user_id));
 		$response = $this->post($request);
 		return new UserResponse($response);
 	}
@@ -71,7 +67,7 @@ public function lookupUser($user_id)
 	public function checkOutItem($user_id, $item_id)
 	{
 		$request = new CheckOutRequest($this->connector->agency_id, $user_id, $item_id);
-		$this->emitter->emit('request.checkout', array($user_id, $item_id));
+		$this->emit('request.checkout', array($user_id, $item_id));
 		$response = $this->post($request);
 		return new CheckOutResponse($response);
 	}
@@ -85,7 +81,7 @@ public function checkOutItem($user_id, $item_id)
 	public function checkInItem($item_id)
 	{
 		$request = new CheckInRequest($this->connector->agency_id, $item_id);
-		$this->emitter->emit('request.checkin', array($item_id));
+		$this->emit('request.checkin', array($item_id));
 		$response = $this->post($request);
 		return new CheckInResponse($response);
 	}
@@ -100,7 +96,7 @@ public function checkInItem($item_id)
 	public function renewItem($user_id, $item_id)
 	{
 		$request = new RenewRequest($user_id, $item_id);
-		$this->emitter->emit('request.renew', array($user_id, $item_id));
+		$this->emit('request.renew', array($user_id, $item_id));
 		$response = $this->post($request);
 		return new RenewResponse($response);
 	}
@@ -114,7 +110,7 @@ public function renewItem($user_id, $item_id)
 	public function lookupItem($item_id)
 	{
 		$request = new ItemRequest($item_id);
-		$this->emitter->emit('request.item', array($item_id));
+		$this->emit('request.item', array($item_id));
 		$response = $this->post($request);
 		return new ItemResponse($response);
 	}

src/Scriptotek/Ncip/NcipService.php

@@ -7,8 +7,9 @@
  */
 
 use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
+use Evenement\EventEmitter;
 
-class NcipService {
+class NcipService extends EventEmitter {
 
 	public $namespaces;
 

tests/NcipClientTest.php

@@ -40,4 +40,31 @@ public function testInvalidResponse() {
 		$response = $this->ncip->lookupUser('test123456');
 	}
 
+	public function testEvents()
+	{
+		$u = 'Mr. Nelson';
+		$i = 'Unit testing decoded';
+		$this->conn->shouldReceive('post')
+			->once()
+			->andReturn($this->dummyCheckoutResponse(array(
+				'userId' => $u,
+				'itemId' => $i,
+			  ))->xml());
+
+		$listenerCalled = 0;
+		$receivedUserId = '';
+		$receivedItemId = '';
+		$this->ncip->on('request.checkout', function($userId, $itemId) use (&$listenerCalled, &$receivedUserId, &$receivedItemId) {
+			$listenerCalled++;
+			$receivedUserId = $userId;
+			$receivedItemId = $itemId;
+		});
+
+		$this->assertEquals(0, $listenerCalled);
+		$this->ncip->checkOutItem($u, $i);
+        $this->assertEquals(1, $listenerCalled);
+        $this->assertEquals($u, $receivedUserId);
+        $this->assertEquals($i, $receivedItemId);
+	}
+
 }