Skip to content

Commit fc6d14d

Browse files
committed
🐛 修复脚本列表页一些警告问题
1 parent bb7d4d5 commit fc6d14d

File tree

6 files changed

+23
-20
lines changed

6 files changed

+23
-20
lines changed

src/locales/en-US/translation.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ silent_update_non_critical_changes: Silent Update Non-critical Script Changes
4343
enable_eslint: Enable ESLint
4444
eslint_rules: ESLint Rules
4545
enter_eslint_rules: Please Enter ESLint Rules, Configurations Can Be Downloaded from https://eslint.org/play/
46+
language_change_tip: Language Change Successful
4647

4748
# Tools Page Tools
4849
backup: Backup

src/locales/zh-CN/translation.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ silent_update_non_critical_changes: 非重要变更静默更新脚本
4343
enable_eslint: 开启 ESLint
4444
eslint_rules: ESLint规则
4545
enter_eslint_rules: 请输入 ESLint 规则,可以从 https://eslint.org/play/ 下载配置
46+
language_change_tip: 语言切换成功
4647

4748
# 工具页 Tools
4849
backup: 备份

src/pages/options/routes/ScriptList.tsx

+7-6
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ import CloudScriptPlan from "@App/pages/components/CloudScriptPlan";
7070
import SynchronizeController from "@App/app/service/synchronize/controller";
7171
import { useTranslation } from "react-i18next";
7272
import { nextTime, semTime } from "@App/pkg/utils/utils";
73-
import { getValues, listHomeRender, scriptListSort } from "./utils";
73+
import { getValues, ListHomeRender, scriptListSort } from "./utils";
7474

7575
type ListType = Script & { loading?: boolean };
7676

@@ -377,13 +377,13 @@ function ScriptList() {
377377
key: "home",
378378
width: 100,
379379
render(col, item: Script) {
380-
return listHomeRender(item);
380+
return <ListHomeRender script={item} />;
381381
},
382382
},
383383
{
384384
title: t("sorting"),
385385
dataIndex: "sort",
386-
key: "sort",
386+
key: "id",
387387
width: 80,
388388
sorter: (a, b) => a.sort - b.sort,
389389
align: "center",
@@ -607,7 +607,7 @@ function ScriptList() {
607607
);
608608

609609
// eslint-disable-next-line react/no-unstable-nested-components
610-
const SortableWrapper = (props: any) => {
610+
const SortableWrapper = (props: any, ref: any) => {
611611
return (
612612
<DndContext
613613
sensors={sensors}
@@ -639,7 +639,7 @@ function ScriptList() {
639639
items={scriptList}
640640
strategy={verticalListSortingStrategy}
641641
>
642-
<tbody {...props} />
642+
<table ref={ref} {...props} />
643643
</SortableContext>
644644
</DndContext>
645645
);
@@ -680,8 +680,9 @@ function ScriptList() {
680680
};
681681

682682
const components: ComponentsProps = {
683+
table: React.forwardRef(SortableWrapper),
683684
body: {
684-
tbody: SortableWrapper,
685+
// tbody: SortableWrapper,
685686
row: SortableItem,
686687
},
687688
};

src/pages/options/routes/Setting.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ function Setting() {
7474
).toLocaleLowerCase()
7575
);
7676
localStorage.language = value;
77+
Message.success(t("language_change_tip")!);
7778
}}
7879
>
7980
{languageList.map((item) => (

src/pages/options/routes/utils.tsx

+13-13
Original file line numberDiff line numberDiff line change
@@ -93,71 +93,71 @@ export function installUrlToHome(installUrl: string) {
9393
return undefined;
9494
}
9595

96-
export function listHomeRender(item: Script) {
96+
export function ListHomeRender({ script }: { script: Script }) {
9797
const { t } = useTranslation();
9898
let home;
99-
if (!item.metadata.homepageurl) {
100-
home = installUrlToHome(item.downloadUrl || "");
99+
if (!script.metadata.homepageurl) {
100+
home = installUrlToHome(script.downloadUrl || "");
101101
}
102102
return (
103103
<Space size="mini">
104104
{home && <Tooltip content={t("homepage")}>{home}</Tooltip>}
105-
{item.metadata.homepage && (
105+
{script.metadata.homepage && (
106106
<Tooltip content={t("homepage")}>
107107
<Button
108108
type="text"
109109
iconOnly
110110
icon={<IconHome />}
111111
size="small"
112-
href={item.metadata.homepage[0]}
112+
href={script.metadata.homepage[0]}
113113
target="_blank"
114114
/>
115115
</Tooltip>
116116
)}
117-
{item.metadata.homepageurl && (
117+
{script.metadata.homepageurl && (
118118
<Tooltip content={t("homepage")}>
119119
<Button
120120
type="text"
121121
iconOnly
122122
icon={<IconHome />}
123123
size="small"
124-
href={item.metadata.homepageurl[0]}
124+
href={script.metadata.homepageurl[0]}
125125
target="_blank"
126126
/>
127127
</Tooltip>
128128
)}
129-
{item.metadata.website && (
129+
{script.metadata.website && (
130130
<Tooltip content={t("script_website")}>
131131
<Button
132132
type="text"
133133
iconOnly
134134
icon={<IconHome />}
135135
size="small"
136-
href={item.metadata.website[0]}
136+
href={script.metadata.website[0]}
137137
target="_blank"
138138
/>
139139
</Tooltip>
140140
)}
141-
{item.metadata.source && (
141+
{script.metadata.source && (
142142
<Tooltip content={t("script_source")}>
143143
<Button
144144
type="text"
145145
iconOnly
146146
icon={<IconCode />}
147147
size="small"
148-
href={item.metadata.source[0]}
148+
href={script.metadata.source[0]}
149149
target="_blank"
150150
/>
151151
</Tooltip>
152152
)}
153-
{item.metadata.supporturl && (
153+
{script.metadata.supporturl && (
154154
<Tooltip content={t("bug_feedback_script_support")}>
155155
<Button
156156
type="text"
157157
iconOnly
158158
icon={<IconBug />}
159159
size="small"
160-
href={item.metadata.supporturl[0]}
160+
href={script.metadata.supporturl[0]}
161161
target="_blank"
162162
/>
163163
</Tooltip>

src/pkg/utils/utils.ts

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import Logger from "@App/app/logger/logger";
66
import MessageInternal from "@App/app/message/internal";
77
import { CronTime } from "cron";
88
import dayjs from "dayjs";
9-
import "dayjs/locale/zh-cn";
109
import semver from "semver";
1110
import { enc, MD5 } from "crypto-js";
1211

0 commit comments

Comments
 (0)