Add sqlWhereAnyE #16
Add sqlWhereAnyE #16
Conversation
| let sql = sqlForWhereAny l | ||
| sqlWhereE (DBBaseLineConditionIsFalse sql) sql | ||
|
|
||
| sqlWhereAnyE :: (DBExtraException e, MonadState v m, SqlWhere v) => e -> [State SqlAll ()] -> m () |
There was a problem hiding this comment.
I'm aware that most top-level functions in this file lack Haddock comments, but would be nice if we started adding them to the new ones at least.
| sqlWhereAny l = sqlWhere $ "(" <+> smintercalate "OR" (map (parenthesize . toSQLCommand . flip execState (SqlAll [])) l) <+> ")" | ||
| sqlWhereAny l = do | ||
| let sql = sqlForWhereAny l | ||
| sqlWhereE (DBBaseLineConditionIsFalse sql) sql |
There was a problem hiding this comment.
Can't you just sqlWhere here instead of inlining it?
| sqlWhereAnyE :: (DBExtraException e, MonadState v m, SqlWhere v) => e -> [State SqlAll ()] -> m () | ||
| sqlWhereAnyE e = sqlWhereE e . sqlForWhereAny | ||
|
|
||
| sqlForWhereAny :: [State SqlAll ()] -> SQL |
There was a problem hiding this comment.
sqlFor naming convention is not used anywhere else in this file, IMO something like sqlWhereAnyImpl would be more self-explanatory.
| sqlWhereAnyE :: (DBExtraException e, MonadState v m, SqlWhere v) => e -> [State SqlAll ()] -> m () | ||
| sqlWhereAnyE e = sqlWhereE e . sqlForWhereAny | ||
|
|
||
| sqlForWhereAny :: [State SqlAll ()] -> SQL |
There was a problem hiding this comment.
[State SqlAll ()]
From looking at the code, it seems that it would make sense to add a SqlAny newtype as well, though that's a bigger refactoring (and therefore not required for this PR to be merged).
|
Travis failure is due to the released |
|
Made a Hackage revision for hpqtypes-1.6.0.0, this should made the build green. |
|
It's green, merging. Will do a minor release later today. |
|
Released |
No description provided.