-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-downtime migrations support for composite types #21
Changes from 3 commits
b81ddb5
a411f5b
c175d30
29b2e6f
1391482
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ import Prelude | |
data Check = Check { | ||
chkName :: RawSQL () | ||
, chkCondition :: RawSQL () | ||
, chkValidated :: Bool -- ^ Set to 'True' if check is created as NOT VALID and | ||
, chkValidated :: Bool -- ^ Set to 'False' if check is created as NOT VALID and | ||
-- not validated afterwards. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/not validated/validated/? We're supposed to call Maybe rephrase as: "When set to 'False', the check is initially created as NOT VALID. It should be eventually validated with 'sqlValidateCheck'.". Similarly for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
OK, maybe change both comments to say this instead of current wording? I find it less confusing than the current one (with the double negative). |
||
} deriving (Eq, Ord, Show) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
ptype
seems to always be "columns", maybe these two should beobjectHas{Less,More}Columns
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it as-is, I don't think it's a big deal.