Extend checkDatabaseAllowUnknownTables to allow unknown composite types #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23Skidoo
approved these changes
May 20, 2019
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # hpqtypes-extras-1.8.0.0 (2019-05-21) | |||
| @@ -749,35 +749,35 @@ migrationTest2 connSource = | |||
| checkDatabase extrasOptions [] [] currentSchema | |||
| assertNoException "checkDatabaseAllowUnknownTables runs fine \ | |||
| \for consistent DB" $ | |||
| checkDatabaseAllowUnknownTables extrasOptions [] [] currentSchema | |||
| checkDatabaseAllowUnknownObjects extrasOptions [] [] currentSchema | |||
There was a problem hiding this comment.
Shouldn't we also add a test to this file that checks that unknown composites are accepted?
|
I updated changelog and tests, should be good to merge now. |
|
Travis is red, looks like it's due to a missing upper bound and a Haddock error. |
|
Ok, it's good now (travis failed for some but it's its fault). |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.