-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make eip2718 & eip1559 configurable in txpool #206
Conversation
Add two configs in ChainConfig:
Only disable EIP-1559 (type 0x02 disabled):
|
Is it ok to disable |
This will disable Berlin Hard Fork and London Hard Fork, which would disable some other EIPs (may be useful). |
Incompatibility issue: MetaMask chooses eip1559 when |
Ok, add |
d8d5ed0
to
e1071df
Compare
8c178e0
to
f562283
Compare
3980ae3
to
d96820c
Compare
d96820c
to
d7e8e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
background:
circuit only support legacy tx but cannot support Typed Transaction Envelope tx. We plan to support non legacy tx within months. So here i disable non-legacy tx at txpool level but not consensus level. all the sequencers within months will be "non-evil", they will not deliberately produce blocks with Typed Transaction Envelope. So as long as we support non-legacy tx before scroll network becomes decentralied (i believe this), this PR is a good solution.
alternative solutions:
(1) disable London/Berlin. We will miss a lot of new features
(2) disable some related EIPs. I find it is not easy.. Forks and eips are coupled tightly in codes, and i think using this solution we need to modify much more codes and much more error-prone.